Skip to content

Conversation

@Jerry-Ge
Copy link
Member

@Jerry-Ge Jerry-Ge commented Dec 2, 2024

To match the latest specification: https://www.mlplatform.org/tosa/tosa_spec.html#_pow

@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/pr-subscribers-mlir-tosa

Author: Jerry-Ge (Jerry-Ge)

Changes

To match the latest specification: https://www.mlplatform.org/tosa/tosa_spec.html#_pow


Full diff: https://github.com/llvm/llvm-project/pull/118407.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td (+1-1)
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index 9f57efff5d1fd2..c786f396a24cdf 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -828,7 +828,7 @@ def Tosa_PowOp : Tosa_ElementwiseOp<"pow", [SameOperandsAndResultElementType]> {
   );
 
   let results = (outs
-    Tosa_Tensor:$z
+    Tosa_Tensor:$output
   );
 }
 

@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/pr-subscribers-mlir

Author: Jerry-Ge (Jerry-Ge)

Changes

To match the latest specification: https://www.mlplatform.org/tosa/tosa_spec.html#_pow


Full diff: https://github.com/llvm/llvm-project/pull/118407.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td (+1-1)
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index 9f57efff5d1fd2..c786f396a24cdf 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -828,7 +828,7 @@ def Tosa_PowOp : Tosa_ElementwiseOp<"pow", [SameOperandsAndResultElementType]> {
   );
 
   let results = (outs
-    Tosa_Tensor:$z
+    Tosa_Tensor:$output
   );
 }
 

@joker-eph joker-eph changed the title Update PowOp's dialect output name from z to output [MLIR][TOSA] Update PowOp output name from z to output Dec 3, 2024
@CoTinker CoTinker requested a review from eric-k256 December 3, 2024 06:51
Copy link
Contributor

@eric-k256 eric-k256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@CoTinker CoTinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoTinker CoTinker merged commit f4ce7e0 into llvm:main Dec 3, 2024
11 checks passed
@Jerry-Ge Jerry-Ge deleted the OpPow branch December 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants